Skip to content

Commit

Permalink
Fixed missing check ISA fields in RVTEST_CASE for new div and amo tes…
Browse files Browse the repository at this point in the history
…ts. Without these fields, RISCOF reports 'Test Selected without the relevant extensions being available on DUT.'
  • Loading branch information
davidharrishmc committed Oct 11, 2023
1 parent 751348f commit 522da8c
Show file tree
Hide file tree
Showing 30 changed files with 32 additions and 29 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# CHANGELOG

# [3.7.5] - 2023-10-11
Add missing check ISA fields in recently modified div and amo tests
## [3.7.4] - 2023-10-04
- Fix typos in CONTRIBUTION.md

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv32i_m/A/src/amoadd.w-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoadd.w)
RVTEST_CASE(0,"//check ISA:=regex(.*32.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoadd.w)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv32i_m/A/src/amoand.w-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoand.w)
RVTEST_CASE(0,"//check ISA:=regex(.*32.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoand.w)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv32i_m/A/src/amomax.w-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amomax.w)
RVTEST_CASE(0,"//check ISA:=regex(.*32.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amomax.w)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv32i_m/A/src/amomaxu.w-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amomaxu.w)
RVTEST_CASE(0,"//check ISA:=regex(.*32.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amomaxu.w)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv32i_m/A/src/amomin.w-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amomin.w)
RVTEST_CASE(0,"//check ISA:=regex(.*32.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amomin.w)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv32i_m/A/src/amominu.w-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amominu.w)
RVTEST_CASE(0,"//check ISA:=regex(.*32.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amominu.w)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv32i_m/A/src/amoor.w-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoor.w)
RVTEST_CASE(0,"//check ISA:=regex(.*32.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoor.w)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv32i_m/A/src/amoswap.w-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoswap.w)
RVTEST_CASE(0,"//check ISA:=regex(.*32.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoswap.w)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv32i_m/A/src/amoxor.w-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoxor.w)
RVTEST_CASE(0,"//check ISA:=regex(.*32.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoxor.w)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv32i_m/M/src/div-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*M.*);def TEST_CASE_1=True;",div)
RVTEST_CASE(0,"//check ISA:=regex(.*32.*);check ISA:=regex(.*I.*M.*);def TEST_CASE_1=True;",div)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/A/src/amoadd.d-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoadd.d)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoadd.d)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/A/src/amoadd.w-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoadd.w)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoadd.w)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/A/src/amoand.d-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoand.d)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoand.d)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/A/src/amoand.w-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoand.w)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoand.w)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/A/src/amomax.d-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amomax.d)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amomax.d)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/A/src/amomax.w-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amomax.w)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amomax.w)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/A/src/amomaxu.d-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amomaxu.d)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amomaxu.d)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/A/src/amomaxu.w-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amomaxu.w)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amomaxu.w)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/A/src/amomin.d-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amomin.d)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amomin.d)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/A/src/amomin.w-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amomin.w)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amomin.w)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/A/src/amominu.d-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amominu.d)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amominu.d)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/A/src/amominu.w-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amominu.w)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amominu.w)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/A/src/amoor.d-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoor.d)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoor.d)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/A/src/amoor.w-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoor.w)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoor.w)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/A/src/amoswap.d-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoswap.d)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoswap.d)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/A/src/amoswap.w-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoswap.w)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoswap.w)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/A/src/amoxor.d-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoxor.d)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoxor.d)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/A/src/amoxor.w-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoxor.w)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*A.*);def TEST_CASE_1=True;",amoxor.w)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down
2 changes: 1 addition & 1 deletion riscv-test-suite/rv64i_m/M/src/div-01.S
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ RVTEST_CODE_BEGIN

#ifdef TEST_CASE_1

RVTEST_CASE(0,"//check ISA:=regex(.*I.*M.*);def TEST_CASE_1=True;",div)
RVTEST_CASE(0,"//check ISA:=regex(.*64.*);check ISA:=regex(.*I.*M.*);def TEST_CASE_1=True;",div)

RVTEST_SIGBASE(x1,signature_x1_1)

Expand Down

0 comments on commit 522da8c

Please sign in to comment.