Skip to content

Commit

Permalink
Merge pull request #384 from visitorckw/fix/typo
Browse files Browse the repository at this point in the history
Fix typos in CONTRIBUTION.md
  • Loading branch information
allenjbaum authored Oct 4, 2023
2 parents a5a49fc + fb41944 commit 47cc654
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
# CHANGELOG
## [3.7.4] - 2023-10-04
- Fix typos in CONTRIBUTION.md

## [3.7.3] - 2023-09-29
- Added test RV32i_m/div-01.S and RV64i_m/div-01.S tests.
- Added tests for resolving missing coverage issue of harcoded registers[issue #306](https://github.com/riscv-non-isa/riscv-arch-test/issues/306)
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTION.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ Pull requests are the best way to propose changes to the codebase. We actively w
4. If you have updated the docs, ensure that they render correctly in the respective format.
5. Make sure to create an entry in the CHANGELOG.md. Please refer to the section on versioning below
to choose an appropriate version number.
6. Ensure the existing tests are not broken and still pass on the the RVI approved reference models.
6. Ensure the existing tests are not broken and still pass on the RVI approved reference models.
7. Please include a comment with the SPDX license identifier in all source files, for example:
```
// SPDX-License-Identifier: BSD-3-Clause
Expand All @@ -34,7 +34,7 @@ Pull requests are the best way to propose changes to the codebase. We actively w

## Uploading Test Stats

If your PR is adding new tests or modifying existing tests, then you are be expected to
If your PR is adding new tests or modifying existing tests, then you are expected to
run the coverage on the new tests (via [RISCOF's coverage mode]((https://riscof.readthedocs.io/en/stable/commands.html#coverage)))
and upload the coverage and data propagation reports to [this Google Drive folder](https://drive.google.com/drive/folders/153nIRznXwzu7N1rWl9CesqwAXLqwHoEx?usp=share_link).
In this folder create a new folder with the PR number as the name. The stat files must be zipped and
Expand Down

0 comments on commit 47cc654

Please sign in to comment.