hgatp_mode in riscv_virt2phys_v defined by vsatp value #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `vsatp` with `hgatp` (how it should be) Change-Id: Ie548467b06d1fb266ccc56cbec1aff8d9f435973
kr-sc
force-pushed
the
kr-sc/fix-hgatp-mode-upstream
branch
from
2773962
to
1097720
Compare
JanMatCodasip
approved these changes
Oct 24, 2023
|
@kr-sc Thank you. Curious - has this been discovered by code review or by some sort of static analysis tool? |
By code review, in process of investigating for this #904. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
vsatpwithhgatp(how it should be)