add diagnostics for non-implemented data watchpoints #897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timsifive
requested changes
Aug 1, 2023
src/target/riscv/riscv.c
Outdated
| // replaced by WATCHPOINT_IGNORE_DATA_VALUE_MASK once it is available | ||
| // See: https://review.openocd.org/c/openocd/+/7840 | ||
| if (watchpoint->mask != ~(typeof(watchpoint->mask))0) { | ||
| LOG_ERROR("watchpoints on data values are not implemented"); |
There was a problem hiding this comment.
Suggested change
| LOG_ERROR("watchpoints on data values are not implemented"); | |
| LOG_TARGET_ERROR(target, "watchpoints on data values are not implemented"); |
aap-sc
force-pushed
the
aap-sc/wp_data_not_implemented
branch
from
2f5e289
to
f36ae13
Compare
MarekVCodasip
previously approved these changes
Aug 2, 2023
src/target/riscv/riscv.c
Outdated
| // replaced by WATCHPOINT_IGNORE_DATA_VALUE_MASK once it is available | ||
| // See: https://review.openocd.org/c/openocd/+/7840 | ||
| if (watchpoint->mask != ~(typeof(watchpoint->mask))0) { | ||
| LOG_TARGET_ERROR(target, "watchpoints on data values are not implemented"); |
There was a problem hiding this comment.
One tiny thing, I would capitalize the first letter in the "watchpoints" error log
Change-Id: If5031c6d8cea1bfcc34bb65fd766f232498ed7ea Signed-off-by: Parshintsev Anatoly <[email protected]>
aap-sc
force-pushed
the
aap-sc/wp_data_not_implemented
branch
from
f36ae13
to
bb78526
Compare
MarekVCodasip
approved these changes
Aug 7, 2023
timsifive
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: If5031c6d8cea1bfcc34bb65fd766f232498ed7ea