Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

target/riscv: support disable auto fence #1157

Open
wants to merge 1 commit into
base: riscv
Choose a base branch
from

Conversation

zqb-all
Copy link
Contributor

@zqb-all zqb-all commented Oct 29, 2024

Support disable automatic fence, it's useful for debug some cache related issue.

@aap-sc
Copy link
Collaborator

aap-sc commented Oct 29, 2024

@zqb-all I'm not sure we need the functionality of riscv fence command, since we already have capabilities to execute instructions from program buffer directly. Have you tried riscv exec_progbuf command?

@aap-sc
Copy link
Collaborator

aap-sc commented Oct 29, 2024

as for auto fence - it looks reasonable

@zqb-all
Copy link
Contributor Author

zqb-all commented Oct 30, 2024

@zqb-all I'm not sure we need the functionality of riscv fence command, since we already have capabilities to execute instructions from program buffer directly. Have you tried riscv exec_progbuf command?

Thanks, I didn't notice this command before. With this command, I agree that a separate fence command is not needed

@zqb-all zqb-all force-pushed the support-disable-auto-fence branch 2 times, most recently from d6dfb9c to b127d56 Compare October 30, 2024 02:01
Support disable automatic fence, it's useful for
debug some cache related issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants