Fix riscv013_invalidate_cached_progbuf()

[TommyMurphyTM1234]

Fix for this issue:

• riscv013 Invalidate cache function does not invalidate complete progbuf-cache (off by one error?) #1139

Using memset() instead of manual loop to zeroize the whole array since memset() is used elsewhere for similar purposes and is more reliable (no miscounting elements).

[TommyMurphyTM1234]

Failed on checkpatch? Sigh - that thing seems like such a waste of time... :-|

This is simply incorrect:

ERROR:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

The commit DOES have a commit description.

• 8317e0f

git commit -m "Fix riscv013_invalidate_cached_progbuf() - see https://github.com/riscv-collab/riscv-openocd/issues/1139"

[JanMatCodasip]

The checkpatch script seems to expect commit messages in this format:

Commit title - single line
<blank line>
Commit description - one or more lines

In your case, the "description" part appears missing.

I understand that the checkpatch script may be annoying at times, but in this case:

• the fix is trivial,
• forcing committers to take the time to describe their changes has an added value.

Thank you for the patch.

[TommyMurphyTM1234]

The checkpatch script seems to expect commit messages in this format:

Commit title - single line
<blank line>
Commit description - one or more lines

In your case, the "description" part appears missing.

I understand that the checkpatch script may be annoying at times, but in this case:

• the fix is trivial,
• forcing committers to take the time to describe their changes has an added value.

Thank you for the patch.

Ok, thanks @JanMatCodasip. I'd forgotten about that requirement and am used to repos that aren't so picky about the commit message and allow a single line. It would be more helpful if checkpatch actually gave a more accurate and prescriptive error message in this case. I'll update the commit/PR this morning to fix the commit message.

[TommyMurphyTM1234]

The checkpatch script seems to expect commit messages in this format:

Commit title - single line
<blank line>
Commit description - one or more lines

In your case, the "description" part appears missing.
I understand that the checkpatch script may be annoying at times, but in this case:

• the fix is trivial,
• forcing committers to take the time to describe their changes has an added value.

Thank you for the patch.

Ok, thanks @JanMatCodasip. I'd forgotten about that requirement and am used to repos that aren't so picky about the commit message and allow a single line. It would be more helpful if checkpatch actually gave a more accurate and prescriptive error message in this case. I'll update the commit/PR this morning to fix the commit message.

OMG - checkpatch is such a waste of time!

ERROR:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#7: 
riscv013_invalidate_cached_progbuf() was failing to zeroize the final buffer array element.

[TommyMurphyTM1234]

Third time lucky?

Edit: looks like it - phew!

[en-sc]

LGTM

[JanMatCodasip]

LGTM.

@TommyMurphyTM1234 Thanks for your patience with checkpatch :-)

[TommyMurphyTM1234]

LGTM.

Thanks a lot @JanMatCodasip.

@TommyMurphyTM1234 Thanks for your patience with checkpatch :-)

Apologies for venting - hopefully I'll remember its vagaries next time! 😄