target/riscv: Mismatch napot when mcontrol.maskmax is not expected #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.Remove trigger_request_info::tdata1_ignore_mask
2.Adding ignore napot matching condition
Signed-off-by: zhusonghe <[email protected]>
| tdata1_config_denied = (tdata1 & ~maskmax) != (tdata1_rb & ~maskmax); | ||
| } else { | ||
| tdata1_config_denied = tdata1 != tdata1_rb; | ||
| } |
There was a problem hiding this comment.
else if() and else () are my considered,please check it is reasonable?
| @@ -727,13 +758,11 @@ static int maybe_add_trigger_t1(struct target *target, struct trigger *trigger) | |||
| struct trigger_request_info { | |||
| riscv_reg_t tdata1; | |||
| riscv_reg_t tdata2; | |||
| riscv_reg_t tdata1_ignore_mask; | |||
There was a problem hiding this comment.
from PR:#1127
according discussion,remove tdata1_ignore_mask
|
@sunnyzhu-learning, please, take a look at build and Checkpatch failures. Also I'd like to ask you to continue the review in the previous PR to simplify the review process. And reopen the PR on github. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to code conflict，
this PR（https://github.com/riscv-collab/riscv-openocd/pull/1127）closed,
and then recreated a PR to solve question
code review all addressed，@en-sc @JanMatCodasip please check below code,thanks