Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instructions for macOS #1602

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

sbeamer
Copy link
Contributor

@sbeamer sbeamer commented Oct 28, 2024

The version of make included with macOS is from 2006 due to Apple's aversion to GPLv3. It is finally too old to build this repo. When installing a newer version of make with Homebrew, it is labelled gmake to not override the existing make.

@pz9115
Copy link
Contributor

pz9115 commented Oct 31, 2024

LGTM, and I think we need re-trigger the CI check to see if it works well.

@TommyMurphyTM1234
Copy link
Collaborator

LGTM, and I think we need re-trigger the CI check to see if it works well.

Why? This is a change to the readme only and, in any case, the CI actions don't do any macOS builds.

Copy link
Collaborator

@cmuellner cmuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmuellner cmuellner merged commit 7317ccf into riscv-collab:master Oct 31, 2024
2 of 26 checks passed
@cmuellner
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants