CI/CD: Bump upload-artifact to v4 #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently updated the download-artifact action to v4, because earlier
versions were deprecated and stopped working.
Now we ran into the situation, that the release pipeline broke, because
no toolchains are found by the download-artifact action
("Found 0 artifact(s)" although all toolchain builds succeeded and the
resulting toolchain was successfully archived and uploaded).
Looking into the documention of download-artifact@v4 shows the issue:
One of the breaking changes of download-artifact@v4 is "Downloading
artifacts that were created from action/upload-artifact@v3 and below
are not supported." ([1]). Our pipeline uses upload-artifact@v3, which
is why they are not found later on.
Let's bump the upload-artifact action to v4 so that download-artifact@v4
will find the built artifacts again.
[1] https://github.com/actions/download-artifact?tab=readme-ov-file#v4---whats-new
Signed-off-by: Christoph Müllner <[email protected]>
|
LGTM，thanks! |
|
I'm merging this without a formal review from somebody else. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently updated the download-artifact action to v4, because earlier versions were deprecated and stopped working.
Now we ran into the situation, that the release pipeline broke, because no toolchains are found by the download-artifact action ("Found 0 artifact(s)" although all toolchain builds succeeded and the resulting toolchain was successfully archived and uploaded).
Looking into the documention of download-artifact@v4 shows the issue: One of the breaking changes of download-artifact@v4 is "Downloading artifacts that were created from action/upload-artifact@v3 and below are not supported." ([1]). Our pipeline uses upload-artifact@v3, which is why they are not found later on.
Let's bump the upload-artifact action to v4 so that download-artifact@v4 will find the built artifacts again.
[1] https://github.com/actions/download-artifact?tab=readme-ov-file#v4---whats-new