fix NEWLIB_MULTILIB_NAMES in Makefile #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
see #1513 |
|
So it looks like we generate useless space characters and fix this later. |
|
ok, I'll try a fix in Makefile.in |
MetaLambda
force-pushed
the
fix-multilib-generator
branch
from
975c69e
to
1964d04
Compare
|
@cmuellner I modify the Makefile.in to eliminate the useless space at the end of NEWLIB_MULTILIB_NAMES |
see riscv-collab#1513 The NEWLIB_MULTILIB_NAMES generated in makefile for MULTILIB_GEN may contain space at the end, which cause the generate_target_board script to crash Signed-off-by: Bin XIE <[email protected]>
MetaLambda
force-pushed
the
fix-multilib-generator
branch
from
1964d04
to
5184413
Compare
MetaLambda
changed the title
|
Merged after the CI showed that all pipelines were fine. Thanks! |
|
Thanks a lot @MetaLambda! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NEWLIB_MULTILIB_NAMES generated in makefile for MULTILIB_GEN may contain space at the end, which cause the generate_target_board script to crash.