Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump uClibc from v1.0.48-7-gad21b95c9 to v1.0.50 #1564

Merged

Conversation

TommyMurphyTM1234
Copy link
Collaborator

Fix for this issue:

@TommyMurphyTM1234
Copy link
Collaborator Author

TommyMurphyTM1234 commented Oct 7, 2024

Just realised - maybe I should have run the test suite before and after bumping uClibc to sanity check the change?

Edit: but I'm not sure that work was ever done to allow the test suite to run for the Linux/uClibc toolchain?

Edit 2: oh - and, of course, I can't run the "before" test suite anyway since the whole point of this PR is to bump uClibc to fix the broken build! I would have to go back to some earlier version of the various submodules that would build successfully first. I would prefer not to have to do that.

Edit 3: OK - so there is no support in the current Makefile[.in] to run the test suite for the Linux/uClibc (or Linux/musl) toolchain(s) so enabling that would be a separate issue/PR and consequently, at the moment, it's only possible to bump uClibc "blindly" with no sanity checking of the results. I don't know whether or not this might influence the decision to merge or not merge this PR?

@cmuellner
Copy link
Collaborator

Thanks for the PR!

Tests are not supported for uClibc at this point.
So, all we need is a working build process (which is the whole purpose of this PR).

I double-checked the git commit/tag.

Copy link
Collaborator

@cmuellner cmuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmuellner cmuellner merged commit 31a8195 into riscv-collab:master Oct 9, 2024
20 checks passed
@TommyMurphyTM1234
Copy link
Collaborator Author

Thanks @cmuellner! 👍

@TommyMurphyTM1234 TommyMurphyTM1234 deleted the bump-uclibc-to-v1.0.50 branch October 9, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants