-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gccgo build for toolchain. #1554
Conversation
Thanks for the PR! This opens the question of what to do with other questions (Rust, Ada, etc.). Eventually, we might end up enabling all languages and increasing the default build time, which is something we don't want. A solution is to have a configure flag that allows the setting of the enabled languages. We already have similar features like with-abi, with-arch, with-tune, and with-isa-spec. Would you be interested in implementing such a mechanism? |
Do additional languages need additional test suite support or does that get enabled automatically? Also, I always wondered, why is the default language selection (for the Linux toolchains) C/C++/Fortran rather than maybe just C/C++ which I presume would cover the vast majority of RISC-V development scenarios? Is it because C/C++/Fortran is the default selection for upstream GCC? |
Yes, the tests will be enabled automatically.
Short answer: historical reasons. |
Ok, thanks @cmuellner. |
For the record, @cmuellner's guess is right; I enabled Fortran by default a long time ago to build SPEC benchmarks. |
Thanks @aswaterman. |
Oh hi guys. I'd love to mention you that when you choose Then use I thought this problem is caused by Bug 113143 - Remove usage of ucontext.h . |
Can you clarify the exact commands required to do this? I presume it's something like:
|
|
Thanks @ArielHeleneto. I guess that if this PR is eventually merged (having added the configuration option suggested by @cmuellner earlier perhaps?) then this info should probably go in the README. |
Agreed but thinking what should I write in README. I thought adding an option is a better choice as @cmuellner says. |
I agree - having the option to build gccgo and not doing it by default sounds like the right way to go.
Depends on how the option is implemented, what a user needs to do to use it, if there are any additional build prerequisites, if the libucontext stuff for the Musl build needs to be mentioned, if there are any limitations (e.g. I presume that it will only work for a Linux toolchain and not for bare-metal?), etc. |
Hi, I did #1559 in response of your suggestion. I think we can now close this Pull request.
|
Closing in favor or #1559. |
No description provided.