Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Progress for Cloning Submodules #1533

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

karaketir16
Copy link
Contributor

Cloning submodules can be a time-consuming process. This update introduces progress indicators to provide better visibility and feedback during the submodule fetching process, improving the user experience.

@cmuellner
Copy link
Collaborator

Thanks, I did not know this switch, so I quickly tried it out.
So, what this does is show the download speed and the arrived bits.

E.g. before:

$ git submodule update --init 
Submodule path 'foo': checked out '35203a4f123d0be162b6b5ea213a657b594f8c36

After:

$ git submodule update --init --progress
Cloning into 'path/to/foo'...
remote: Enumerating objects: 267, done.        
remote: Counting objects: 100% (105/105), done.        
remote: Compressing objects: 100% (69/69), done.        
remote: Total 267 (delta 42), reused 62 (delta 23), pack-reused 162 (from 1)        
Receiving objects: 100% (267/267), 6.08 MiB | 5.43 MiB/s, done.
Resolving deltas: 100% (102/102), done.
Submodule path 'foo': checked out '35203a4f123d0be162b6b5ea213a657b594f8c36'

I like this change.

Copy link
Collaborator

@cmuellner cmuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmuellner cmuellner merged commit f42ee80 into riscv-collab:master Aug 15, 2024
20 checks passed
@cmuellner
Copy link
Collaborator

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants