Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject CPU options to spike run test from elf file #1370

Merged
merged 3 commits into from
Nov 27, 2023

Conversation

Incarnation-p-lee
Copy link
Contributor

@Incarnation-p-lee Incarnation-p-lee commented Nov 21, 2023

  • Refactor CPU options for exacting common part between qemu and spike.
  • Inject CPU options to spike run command line.

The below common CPU options are extracted for underlying actions.

  • xlen
  • vlen
  • extensions

The above CPU options will be leveraged to build the run arguments for both the qemu and spike, for example.

QEMU: qemu-riscv64 -cpu rv64,v=true,vlen=1024,elen=64,vext_spec=v1.0
SPIKE: spike --isa=rv64imafdcv_zicsr_zifencei_zmmul --varch=vlen:1024,elen:64

* Refactor CPU options for exacting common part between qemu and spike.
* Inject CPU options to spike run command line.

The below common CPU options are extracted to common part.

* xlen
* vlen
* extensions

The above CPU options will be leveraged to build the run arguments for
both the qemu and spike, for example.

QEMU: qemu-riscv64 -cpu rv64,v=true,vlen=1024,elen=64,vext_spec=v1.0
SPIKE: spike --isa=rv64imafdcv_zicsr_zifencei_zmmul --varch=vlen:1024,elen:64

Signed-off-by: Pan Li <[email protected]>
@Incarnation-p-lee
Copy link
Contributor Author

Hi @kito-cheng ,

Looks like some various from the CI, I tested the same code base with another CI, and all passed.
Could you please help to trigger a re-run for failed jobs? Looks like I have no authority to do this.

@kito-cheng
Copy link
Collaborator

rerun failed case now :)

@kito-cheng
Copy link
Collaborator

CI is pass now, let merge!

@kito-cheng kito-cheng merged commit c2b4923 into riscv-collab:master Nov 27, 2023
20 checks passed
@Incarnation-p-lee
Copy link
Contributor Author

CI is pass now, let merge!

Cool, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants