Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump binutils to v2.41 release #1337

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

patrick-rivos
Copy link
Collaborator

@patrick-rivos patrick-rivos commented Oct 2, 2023

@vineetgarc pointed out that the binutils 2.41 actually has 2 release tags. This PR updates binutils to the official 2.41 release.

Tested using make report-binutils-linux and make report-binutils-newlib

There are new failures.

@TommyMurphyTM1234
Copy link
Collaborator

TommyMurphyTM1234 commented Oct 2, 2023

Tested using make report-binutils-linux and make report-binutils-newlib

Do other tests need to be run also?

@patrick-rivos
Copy link
Collaborator Author

Those targets are built as a part of the CI, so I'll keep an eye on it and make sure they pass.

LLVM/musl do not have make targets that run tests so I think a successful build should be sufficient in their case.

@TommyMurphyTM1234
Copy link
Collaborator

Those targets are built as a part of the CI, so I'll keep an eye on it and make sure they pass.

LLVM/musl do not have make targets that run tests so I think a successful build should be sufficient in their case.

OK - fair enough.
I was just mentioning the other tools build targets in case them not being tested was an issue. :-)

@patrick-rivos
Copy link
Collaborator Author

I'm glad you brought it up - it's always nice to have someone else sanity check 😄
& it looks like there's a failure with spike so it's completely warranted ;)

Copy link
Collaborator

@cmuellner cmuellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmuellner cmuellner merged commit c7853bf into riscv-collab:master Oct 5, 2023
20 checks passed
@ewlu ewlu deleted the bump-binutils-release branch January 18, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants