feat: update revm to main
#75
Conversation
|
+r @Wollac |
| @@ -6,7 +6,10 @@ edition = "2021" | |||
| [workspace] | |||
|
|
|||
| [dependencies] | |||
| k256 = { version = "=0.13.1", features = ["std", "ecdsa"], default_features = false } | |||
| k256 = { version = "0.13.1", features = [ | |||
There was a problem hiding this comment.
Now, just ignore the patched k256 crate.
|
No CI has been triggered, so I enabled it and tested the failed case locally. |
This commit updates the CI workflow to include the "pull_request" event for the "main" branch. It also adds necessary steps for checking out the repository, installing dependencies, and running tests, clippy, and formatting checks.
| - run: cargo binstall -y --force cargo-risczero@${{ env.RISC0_VERSION }} | ||
| - run: cargo risczero install --version $RISC0_TOOLCHAIN_VERSION | ||
| - run: cargo test --workspace --all-targets --all-features | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
Formatted by vscode official extension https://marketplace.visualstudio.com/items?itemName=GitHub.vscode-github-actions
|
@dyxushuai thanks for the update. It seems there are two blocker for this:
Because of those two things I've decide to rebase your work on feat/revm-optimism as #76. I guess we can close this PR now, but maybe you could create a separate PR for 6e89207 so we can merge that. |
Yeah, it's a good practice to split the CI change |
|
Ethereum mainnet support
Related #52 (case passed)
There is a small problem here.
The main branch of revm used a newer version of
k256thanzeth's forked.https://github.com/bluealloy/revm/blob/main/crates/precompile/Cargo.toml#L28
We should patch the accelerator code into RustCrypto-elliptic-curves 0.13.3.