Another round of suggestions for the no-relay template #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capossele
added a commit
to risc0/risc0-ethereum
that referenced
this pull request
Feb 22, 2024
This PR includes code from the new no-relay Foundry template, extracted as part of risc0/risc0-foundry-template#82 - add risc0-build-ethereum crate and run cargo sort - add codegen for Solidity - add test for forge fmt and fix issue - prune away fragile functionality - improve doc comment on prove method - add MockRiscZeroVerifier.sol --------- Co-authored-by: Angelo Capossele <[email protected]>
capossele
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to fully walkthrough the template and edit it to make my own app! So I think this is the last round of edits!
Note that it includes a "DO NOT MERGE" comment related the the fact that the
risc0-ethereumref is not on a stable branch.