Suggestions for PR #119 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
capossele
added a commit
that referenced
this pull request
Jun 26, 2024
* add mainnet deployment * fix typos * add note on RISC Zero managed RiscZeroVerifierRouter * fmt * use config files * ignore mainnet broadcast * fix typo * fmt * fix typo * use profile config * fmt * fix typo * use riscZeroVerifierAddress * rename config * simplify gitignore * Suggestions for PR #119 (#122) * refactor to make defaults based on the chainId and support deployment with ledger * add note about the lack of support for hardware wallets * run forge fmt * remove warning tag --------- Co-authored-by: Victor Graf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went ahead and implemented some suggested changes to the mainnet deployment scripts in #119
I also tested this by using the provided commands to depploy to Mainnet. Deployment works! I did not test posting the transaction to set the even number yet. I will do that this afternoon.