Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link to Docker #116

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Fix broken link to Docker #116

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3efb77d
Fix broken link to Docker
nategraf Jun 12, 2024
1d8959a
Merge branch 'main' into victor/fix-docker-link
nategraf Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ The [image ID][image-id], and its importance to security, is explained in more d
RISC0_USE_DOCKER=1 cargo build
```

> ***Note:*** *This requires having Docker installed and in your PATH. To install Docker see [Get Docker].*
> ***Note:*** *This requires having Docker installed and in your PATH. To install Docker see [Get Docker][Docker].*

## Deploy Your Application

Expand Down Expand Up @@ -175,7 +175,7 @@ Below are the primary files in the project directory

[Bonsai]: https://dev.bonsai.xyz/
[Foundry]: https://getfoundry.sh/
[Get Docker]: https://docs.docker.com/get-docker/
[Docker]: https://docs.docker.com/get-docker/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the same link - so the issue was the markdown shorthand or...?

Copy link
Member

@tzerrell tzerrell Jun 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That caught me too initially -- it's

risc0-foundry-template/README.md

Line 102 in 4e8fc10

Producing the [Groth16 SNARK proofs][Groth16] for this test requires running on an x86 machine with [Docker] installed, or using [Bonsai](#configuring-bonsai). Apple silicon is currently unsupported for local proving, you can find out more info in the relevant issues [here](https://github.com/risc0/risc0/issues/1520) and [here](https://github.com/risc0/risc0/issues/1749).
that's being fixed, not any of the lines changed by this PR

Copy link
Contributor

@nuke-web3 nuke-web3 Jun 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#118

[Groth16]: https://www.risczero.com/news/on-chain-verification
[RISC Zero Verifier]: https://github.com/risc0/risc0/blob/release-0.21/bonsai/ethereum/contracts/IRiscZeroVerifier.sol
[RISC Zero installation]: https://dev.risczero.com/api/zkvm/install
Expand Down
Loading