Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#499 Load environment file bases on config #500

Merged
merged 6 commits into from
Mar 10, 2023
Merged

#499 Load environment file bases on config #500

merged 6 commits into from
Mar 10, 2023

Conversation

NFSS10
Copy link
Contributor

@NFSS10 NFSS10 commented Mar 8, 2023 •
edited
Loading

- -
Issue #499
Dependencies --
Decisions - Stop using hardcoded Dropbox link (which is associated with my PlatformE account) and use PlatformE CDN
- Load environment file specified in the config

@NFSS10 NFSS10 added the enhancement New feature or request label Mar 8, 2023
@NFSS10 NFSS10 self-assigned this Mar 8, 2023
@vercel
Copy link

vercel bot commented Mar 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
ripe-sdk ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 9, 2023 at 9:18AM (UTC)

@NFSS10 NFSS10 added the CSR label Mar 8, 2023
@NFSS10 NFSS10 changed the title Ns/499 environment #499 Load environment file bases on config Mar 8, 2023
@NFSS10 NFSS10 requested a review from 3rdvision March 8, 2023 14:25
@NFSS10 NFSS10 assigned 3rdvision and unassigned NFSS10 Mar 8, 2023
@NFSS10 NFSS10 marked this pull request as ready for review March 8, 2023 14:25
3rdvision
3rdvision requested changes Mar 8, 2023
View reviewed changes
Copy link
Contributor

@3rdvision 3rdvision left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small things

src/js/api/brand.js Show resolved Hide resolved
src/js/api/brand.js Outdated Show resolved Hide resolved
src/js/visual/configurator-csr.js Show resolved Hide resolved
src/js/api/brand.js Outdated Show resolved Hide resolved
src/js/visual/configurator-csr.js Show resolved Hide resolved
@3rdvision 3rdvision assigned NFSS10 and unassigned 3rdvision Mar 8, 2023
@NFSS10 NFSS10 requested a review from 3rdvision March 9, 2023 09:20
@NFSS10 NFSS10 assigned 3rdvision and unassigned NFSS10 Mar 9, 2023
@3rdvision 3rdvision assigned NFSS10 and unassigned 3rdvision Mar 10, 2023
@NFSS10 NFSS10 merged commit 9a7493c into master Mar 10, 2023
@NFSS10 NFSS10 deleted the ns/499-environment branch March 10, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3rdvision 3rdvision 3rdvision approved these changes

Assignees

@NFSS10 NFSS10

Labels
CSR enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NFSS10 @3rdvision