Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

644 - add padding to radio group #645

Closed
wants to merge 1 commit into from
Closed

644 - add padding to radio group #645

wants to merge 1 commit into from

Conversation

pmpc94
Copy link
Contributor

@pmpc94 pmpc94 commented Nov 10, 2023

@vercel Vercel
Copy link

vercel bot commented Nov 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ripe-components-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 10, 2023 4:02pm

joao-conde
joao-conde reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@joao-conde joao-conde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change this in the component it will affect all our UIs using it. Applying the padding directly where you are using it (ripe pulse) is probably for the best.

@joao-conde joao-conde assigned pmpc94 and unassigned joao-conde Nov 10, 2023
@pmpc94
Copy link
Contributor Author

pmpc94 commented Nov 13, 2023

applying the changes directly in pulse as this could change other usage of this component

@pmpc94 pmpc94 closed this Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joao-conde joao-conde joao-conde left review comments

Assignees

@pmpc94 pmpc94

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmpc94 @joao-conde