Skip to content
This repository has been archived by the owner on Oct 6, 2023. It is now read-only.

basic extends template functionality #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

garyhiscox
Copy link

Hi Tony,

I have branched the extends functionality and added a MXUnit test - extendsTemplate()

Gary

@dswitzer
Copy link
Collaborator

I didn't think extends was part of the Mustache spec. Did they add it recently?

@garyhiscox
Copy link
Author

http://stackoverflow.com/questions/7925931/can-mustache-templates-do-template-extension

Currently mustache.java, hogan.js and phly_mustache support template
inheritance.
mustache/spec#38

On 20 December 2012 12:58, Dan G. Switzer, II [email protected]:

I didn't think extends was part of the Mustache spec. Did they add it
recently?


Reply to this email directly or view it on GitHubhttps://github.com//pull/21#issuecomment-11572451.

@dswitzer
Copy link
Collaborator

I read all those threads before posting, but it's never been officially added to the language from what I can see.

Since we've been trying to keep Mustache.cfc to support what's in the official spec, what I'd do is create a sub-class of Mustache and add the functionality to that component--which should be fairly straightforward.

That way we expose the functionality for those that want it and if it becomes official, we push into into the base Mustache.cfc.

Does that make sense?

@rip747
Copy link
Owner

rip747 commented Jan 4, 2013

what is the status of this? are we going to merge it?

@dswitzer
Copy link
Collaborator

dswitzer commented Jan 4, 2013

It's not actually part of the official spec as far as I can tell, but there
are implementations that support it. Seems like the best option would be to
sub-class Mustache.cfc and include that in the build. That way we have the
feature for those that need it, but don't have it in the base class.

On Thursday, January 3, 2013, Anthony Petruzzi wrote:

what is the status of this? are we going to merge it?


Reply to this email directly or view it on GitHubhttps://github.com//pull/21#issuecomment-11868052.

Dan G. Switzer, II
[email protected]
http://blog.pengoworks.com/

@rip747
Copy link
Owner

rip747 commented Jan 4, 2013

that's an excellent idea.

@garyhiscox
Copy link
Author

That sounds like a good plan, Time is limited at the moment, I will rework
the code into a sub-class as soon as possible.

On 4 January 2013 02:07, Anthony Petruzzi [email protected] wrote:

that's an excellent idea.


Reply to this email directly or view it on GitHubhttps://github.com//pull/21#issuecomment-11869750.

@rip747
Copy link
Owner

rip747 commented Jan 4, 2013

no rush. take you time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants