Skip to content

Commit

Permalink
Continue skipping SCTP HostPort tests in older k8s versions
Browse files Browse the repository at this point in the history
After no longer skipping these in kops 1.28, the e2e tests began failing again.

It turns out cilium doesn't enable SCTP support by default, it is guarded by a `enable-sctp` config boolean.
In k8s 1.27 the test was also renamed and added [Serial], so it is still being skipped on k8s 1.27+ test jobs
  • Loading branch information
rifelpet committed Aug 21, 2023
1 parent e3645f9 commit ff799a3
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion tests/e2e/pkg/tester/skip_regex.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,17 @@ func (t *Tester) setSkipRegexFlag() error {
if isPre28 {
// These may be fixed in Cilium 1.13 but skipping for now
skipRegex += "|Service.with.multiple.ports.specified.in.multiple.EndpointSlices"
skipRegex += "|should.create.a.Pod.with.SCTP.HostPort"
// https://github.com/cilium/cilium/issues/18241
skipRegex += "|Services.should.create.endpoints.for.unready.pods"
skipRegex += "|Services.should.be.able.to.connect.to.terminating.and.unready.endpoints.if.PublishNotReadyAddresses.is.true"
}
if k8sVersion.Minor < 27 {
// Partially implemented in Cilium 1.13 but kops doesn't enable it
// Ref: https://github.com/cilium/cilium/pull/20033
// K8s 1.27+ added [Serial] to the test case, which is skipped by default
// Ref: https://github.com/kubernetes/kubernetes/pull/113335
skipRegex += "|should.create.a.Pod.with.SCTP.HostPort"
}
} else if networking.KubeRouter != nil {
skipRegex += "|load-balancer|hairpin|affinity\\stimeout|service\\.kubernetes\\.io|CLOSE_WAIT"
skipRegex += "|EndpointSlice.should.support.a.Service.with.multiple"
Expand Down

0 comments on commit ff799a3

Please sign in to comment.