Add comment to remove unused IAM permissions in the future

rifelpet · Jan 4, 2024 · 349de70 · 349de70
1 parent 85da9fb
commit 349de70
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/model/iam/iam_builder.go b/pkg/model/iam/iam_builder.go
@@ -1116,6 +1116,9 @@ func addASLifecyclePolicies(p *Policy, enableHookSupport bool) {
 			"autoscaling:DescribeLifecycleHooks",
 		)
 	}
+	// TODO: remove this after k8s 1.29 support is removed
+	// It is no longer needed as of kops 1.29 but to prevent node bootstrap issues
+	// during kops upgrades we keep the permission until it is guaranteed to not be needed.
 	p.unconditionalAction.Insert(
 		"autoscaling:DescribeAutoScalingInstances",
 	)