Retry when server reports 429 Too Many Requests occurs #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An HTTP/1.1 429 Too Many Requests occurs when: * there are too many requests * server is overloaded The server may respond back with a `Retry-after` field with the value in seconds. For now, we'll just retry immediately. A potential enhancement could be to honor `Retry-after` but, thinking of it, it doesn't fit the bill for `apt-offline` because we want the download operation to conclude immediately rather than wait for `Retry-after` seconds. Thanks: Zoltan Kelemen (Github: misterzed88) Closes: #213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An HTTP/1.1 429 Too Many Requests occurs when:
The server may respond back with a
Retry-afterfield with the value in seconds. For now, we'll just retry immediately. A potential enhancement could be to honorRetry-afterbut, thinking of it, it doesn't fit the bill forapt-offlinebecause we want the download operation to conclude immediately rather than wait forRetry-afterseconds.Thanks: Zoltan Kelemen (Github: misterzed88)
Closes: #213