Pr/config explain keys reverse direction setting #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…() and focus_down()
…he mouse ...by discarding contiguous blocks of MotionNotify events, and only updating on the last MotionNotify event in the event queue
fixed keysExit* config entries not getting used
tooltip: limit width to preview width
Truncating at preview width cuts off too much text from the window title for small previews. Instead of using preview width, calculate the width relative to the main window width.
tooltip: limit width relative to main window
tooltip: truncate text if it does not fit in max width
skippy-xd animation
layout_run(), do_layout() is called only in init
Potentially related: when I press escape, no window is focused? Shouldn't behaviour be to focus on previously focused window?
Potentially related: when I press escape, no window is focused? Shouldn't behaviour be to focus on previously focused window?
Differentiate between focus left/right, prev/next
…ion, which" This reverts commit 0e43b83.
* Add mouse scroll wheel support * Allows mouse button to do nothing on MainWin * Update sample config file on mouse scroll * Mouse scroll starts on MainWin->client_to_focus
* Move EnterNotify logic to MotionNotify * Fix bug in Alt-Tab
Only when tooltip follows mouse option=true, and mouse leaves window
* If tooltip followsMouse=false, show on at window center * Remove tooltip align config option * Correct tooltip mouse focus * Correct tooltip disappearance: Only when tooltip follows mouse option=true, and mouse leaves window * Eliminate tooltip flicker * Remove tooltip followsMouse config option * Fix bug where tooltip text is not updated * Update default tooltip offset (to bottom) * Correct first tooltip focus on paging
* New version 0.7.0 * Remove debug flags in Makefile
but tinting refresh mechanism sucks...
Still hacky code though...
seems fine, (merged)
…ve window, before skippy was ever activated, when cancelling with Esc key Previously there was an oversight or bug in the code, whereby this variable wasn't getting set or used correctly. By moving assignment of variable to place slightly before in the code, skippy can now remember what it was! :Yum: (easy fix) Maybe for some reason(s) this was already working after moving about with the mouse. In different areas of code. This fix is for situation(s) where mouse isn't moved / triggering those alternate code paths. So maybe other places in the code is already OK. (And no need to bother elsewhere)
It's probably gotten a bit broken now, but at minimum at least some basic/medium level(s) functionality works.
…ng / releasing SHIFT of CTRL during TAB-bing
* These regexes are type POSIX regex extended * They have been updated and tested online at https://regex101.com/ In the situation where a configuration value contains any hex color codes (#aaafff) Then the regexp can correctly identify those, but still distinguish the #comment at the end of a line Example test string: iconFillSpec = orig mid mid #00FFFF //fffffoo #Something ;comment Should split out to: matches[1] = "iconFillSpec" matches[2] = "orig mid mid #00FFFF" matches[3] = "//fffffoo #Something ;comment" Where a partial or inexact match of matches[3] it never matters (because it is always discarded).
Thank you felix
This reverts commit 132399f.
…inds settings actually does. (previously was not documented)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply meant as a temporary solution, to clear up so much confusion about what is the intended purpose of these 2 settings.
However that (2/2) is deferred / delayed matter. Recommend to open an issue (indeed probably it should still bother you). So is not included now in PR. Nor should it be.
Very detailed reasons / explains, already have been given in a previous other commentary of PR #163
dreamcat4#163