Merge branch 'flutter:main' into main

CODEOWNERS

@@ -11,6 +11,7 @@ app_dart/lib/src/request_handlers/dart_internal_subscription.dart           @dre
 app_dart/lib/src/request_handlers/file_flaky_issue_and_pr.dart              @keyonghan
 app_dart/lib/src/request_handlers/flush_cache.dart                          @keyonghan
 app_dart/lib/src/request_handlers/get_build_status.dart                     @keyonghan
+app_dart/lib/src/request_handlers/get_build_status_badge.dart               @CaseyHillers
 app_dart/lib/src/request_handlers/get_release_branches.dart                 @CaseyHillers
 app_dart/lib/src/request_handlers/get_repos.dart                            @keyonghan
 app_dart/lib/src/request_handlers/get_status.dart                           @keyonghan

CONTRIBUTING.md

@@ -18,6 +18,12 @@ us first through the issue tracker with your idea so that we can help out and
 possibly guide you. Coordinating up front makes it much easier to avoid
 frustration later on.
 
+### Implementations
+
+1. For existing functionality contributions, please loop corresponding CODEOWNERs in to make sure they know and can provide a review before a merge to avoid potential regressions.
+
+2. For new functionality like an app, please add your application as a top level folder and yourself as the point of contact in the Cocoon CODEOWNERS file. One good example of an existing app is `autosubmit`. Feel free to open an infra bug for any design/support discussions, as we are willing to help out.
+
 ### Code reviews
 
 All submissions, including submissions by project members, require review.

README.md

@@ -8,6 +8,7 @@
 </a>
 
 
+[![Flutter CI Status](https://flutter-dashboard.appspot.com/api/public/build-status-badge?repo=cocooon)](https://flutter-dashboard.appspot.com/#/build?repo=cocoon&branch=main)
 [![OpenSSF Scorecard](https://api.securityscorecards.dev/projects/github.com/flutter/cocoon/badge)](https://api.securityscorecards.dev/projects/github.com/flutter/cocoon)
 [![SLSA 3](https://slsa.dev/images/gh-badge-level3.svg)](https://slsa.dev)
 
@@ -70,24 +71,14 @@ All the commands in this section assume that you are in the
 
 ### Running a local dev server
 
-**This is for legacy users who were granted old security keys. Due to overground, this is no longer supported.**
-
 ```sh
-$ export GOOGLE_CLOUD_PROJECT=flutter-dashboard-dev # or flutter-dashboard for prod data
-$ export GCLOUD_KEY=#your_secret # Required for reading/writing from Google Cloud
-$ export COCOON_USE_IN_MEMORY_CACHE=true # Use an in memory cache locally instead of redis to prevent corruption
-$ dart bin/server.dart
+dart bin/local_server.dart
 ```
+
 This will output `Serving requests at 0.0.0.0:8080` indicating the server is working.
 
 New requests will be logged to the console.
 
-To develop and test some features, you need to have a local service
-account(key.json) with access to the project you will be connecting to.
-
-If you work for Google you can use the key with flutter-dashboard project
-via [internal doc](https://g3doc.corp.google.com/company/teams/flutter/infrastructure/cocoon/local_development.md?cl=head#test-with-flutter-dashboard-dev-project).
-
 ### Deploying a test version on Google Cloud
 
 To run live tests, build the app, and provide instructions for deploying to

analyze/pubspec.yaml

@@ -12,4 +12,4 @@ dependencies:
 
 dev_dependencies:
   mockito: 5.4.4
-  test_api: 0.6.1
+  test_api: 0.7.0

app_dart/Dockerfile

@@ -4,7 +4,7 @@
 
 
 # Dart Docker official images can be found here: https://hub.docker.com/_/dart
-FROM dart:beta@sha256:e05aaad0f71e9d045e2a45b63a65f85e5e466b1cc1de34e7e684eede45a29d9b
+FROM dart:beta@sha256:4bddd6ccaed32d2d2b8c27bcd71b1ebca13cec47f3abe7b12f640f9432da8e83
 
 WORKDIR /app
 
@@ -14,4 +14,4 @@ RUN dart pub get
 
 # Start server.
 EXPOSE 8080
-CMD ["/usr/lib/dart/bin/dart", "/app/bin/server.dart"]
+CMD ["/usr/lib/dart/bin/dart", "/app/bin/gae_server.dart"]

app_dart/README.md

@@ -11,7 +11,7 @@ This folder contains a Dart based backend for Cocoon.
 and authenticate yourself by running:
 
 ```sh
-gcloud auth login
+gcloud auth application-default login
 gcloud init
 ```
 * [Install Flutter](https://flutter.dev/docs/get-started/install )
@@ -82,20 +82,10 @@ $ gcloud datastore indexes create index.yaml
 
 #### Using physical machine
 
-* Setting up the environment
-
-```sh
-export COCOON_USE_IN_MEMORY_CACHE=true
-```
-
-This environment is needed as you don't have access to the remote redis
-instance during local development.
-
 * Starting server
 
 ```sh
-export COCOON_USE_IN_MEMORY_CACHE=true
-dart bin/server.dart
+dart bin/local_server.dart
 ```
 
 If you see Serving requests at 0.0.0.0:8080 the dev server is working.

app_dart/bin/gae_server.dart

@@ -0,0 +1,78 @@
+// Copyright 2019 The Flutter Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import 'dart:io';
+
+import 'package:appengine/appengine.dart';
+import 'package:cocoon_service/cocoon_service.dart';
+import 'package:cocoon_service/server.dart';
+import 'package:cocoon_service/src/service/commit_service.dart';
+import 'package:gcloud/db.dart';
+
+Future<void> main() async {
+  await withAppEngineServices(() async {
+    useLoggingPackageAdaptor();
+
+    final CacheService cache = CacheService(inMemory: false);
+    final Config config = Config(dbService, cache);
+    final AuthenticationProvider authProvider = AuthenticationProvider(config: config);
+    final AuthenticationProvider swarmingAuthProvider = SwarmingAuthenticationProvider(config: config);
+    final BuildBucketClient buildBucketClient = BuildBucketClient(
+      accessTokenService: AccessTokenService.defaultProvider(config),
+    );
+
+    /// LUCI service class to communicate with buildBucket service.
+    final LuciBuildService luciBuildService = LuciBuildService(
+      config: config,
+      cache: cache,
+      buildBucketClient: buildBucketClient,
+      pubsub: const PubSub(),
+    );
+
+    /// Github checks api service used to provide luci test execution status on the Github UI.
+    final GithubChecksService githubChecksService = GithubChecksService(
+      config,
+    );
+
+    // Gerrit service class to communicate with GoB.
+    final GerritService gerritService = GerritService(config: config);
+
+    /// Cocoon scheduler service to manage validating commits in presubmit and postsubmit.
+    final Scheduler scheduler = Scheduler(
+      cache: cache,
+      config: config,
+      githubChecksService: githubChecksService,
+      luciBuildService: luciBuildService,
+    );
+
+    final BranchService branchService = BranchService(
+      config: config,
+      gerritService: gerritService,
+    );
+
+    final CommitService commitService = CommitService(config: config);
+
+    final Server server = createServer(
+      config: config,
+      cache: cache,
+      authProvider: authProvider,
+      branchService: branchService,
+      buildBucketClient: buildBucketClient,
+      gerritService: gerritService,
+      scheduler: scheduler,
+      luciBuildService: luciBuildService,
+      githubChecksService: githubChecksService,
+      commitService: commitService,
+      swarmingAuthProvider: swarmingAuthProvider,
+    );
+
+    return runAppEngine(
+      server,
+      onAcceptingConnections: (InternetAddress address, int port) {
+        final String host = address.isLoopback ? 'localhost' : address.host;
+        print('Serving requests at http://$host:$port/');
+      },
+    );
+  });
+}

app_dart/bin/local_server.dart

@@ -0,0 +1,84 @@
+// Copyright 2019 The Flutter Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+import 'dart:io';
+
+import 'package:appengine/appengine.dart';
+import 'package:cocoon_service/cocoon_service.dart';
+import 'package:cocoon_service/server.dart';
+import 'package:cocoon_service/src/model/appengine/cocoon_config.dart';
+import 'package:cocoon_service/src/service/commit_service.dart';
+import 'package:cocoon_service/src/service/datastore.dart';
+import 'package:gcloud/db.dart';
+
+import '../test/src/datastore/fake_datastore.dart';
+
+Future<void> main() async {
+  final CacheService cache = CacheService(inMemory: false);
+  final DatastoreDB dbService = FakeDatastoreDB();
+  final DatastoreService datastoreService = DatastoreService(dbService, defaultMaxEntityGroups);
+  await datastoreService.insert(<CocoonConfig>[
+    CocoonConfig.fake(dbService.emptyKey.append(CocoonConfig, id: 'WebhookKey'), 'fake-secret'),
+    CocoonConfig.fake(dbService.emptyKey.append(CocoonConfig, id: 'FrobWebhookKey'), 'fake-secret'),
+  ]);
+  final Config config = Config(dbService, cache);
+  final AuthenticationProvider authProvider = AuthenticationProvider(config: config);
+  final AuthenticationProvider swarmingAuthProvider = SwarmingAuthenticationProvider(config: config);
+  final BuildBucketClient buildBucketClient = BuildBucketClient(
+    accessTokenService: AccessTokenService.defaultProvider(config),
+  );
+
+  /// LUCI service class to communicate with buildBucket service.
+  final LuciBuildService luciBuildService = LuciBuildService(
+    config: config,
+    cache: cache,
+    buildBucketClient: buildBucketClient,
+    pubsub: const PubSub(),
+  );
+
+  /// Github checks api service used to provide luci test execution status on the Github UI.
+  final GithubChecksService githubChecksService = GithubChecksService(
+    config,
+  );
+
+  // Gerrit service class to communicate with GoB.
+  final GerritService gerritService = GerritService(config: config);
+
+  /// Cocoon scheduler service to manage validating commits in presubmit and postsubmit.
+  final Scheduler scheduler = Scheduler(
+    cache: cache,
+    config: config,
+    githubChecksService: githubChecksService,
+    luciBuildService: luciBuildService,
+  );
+
+  final BranchService branchService = BranchService(
+    config: config,
+    gerritService: gerritService,
+  );
+
+  final CommitService commitService = CommitService(config: config);
+
+  final Server server = createServer(
+    config: config,
+    cache: cache,
+    authProvider: authProvider,
+    branchService: branchService,
+    buildBucketClient: buildBucketClient,
+    gerritService: gerritService,
+    scheduler: scheduler,
+    luciBuildService: luciBuildService,
+    githubChecksService: githubChecksService,
+    commitService: commitService,
+    swarmingAuthProvider: swarmingAuthProvider,
+  );
+
+  return runAppEngine(
+    server,
+    onAcceptingConnections: (InternetAddress address, int port) {
+      final String host = address.isLoopback ? 'localhost' : address.host;
+      print('Serving requests at http://$host:$port/');
+    },
+  );
+}