* helper_functions.py --> set ETCD to a warning only if it is not a m… #248
Conversation
…ount point * validate-pre-install.py --> added hashes for different versions of docker * validate-pre-install.py --> added check to see if ETCD is a partition * validate-pre-install.py --> added flags for 'private-registry'
| openshift_server_repo = "rhel-7-server-ose-3.2-rpms" | ||
| elif "3.1" in options.openshift_version: | ||
| openshift_server_repo = "rhel-7-server-ose-3.1-rpms" | ||
| elif "3.3" in options.openshift_version: |
There was a problem hiding this comment.
can we add in 3.4 (and 3.5 while we're at it)?
There was a problem hiding this comment.
@etsauer do we want to just remove the version check and just have it apply what the user provides? Makes maintainability easier instead of having to update scripts. It will fail down the line anyways if it is incorrect
There was a problem hiding this comment.
we can, but sanitation becomes a problem. The current method, crude though it may be, provides a level of sanitation that would have to be rethought if we are just taking whatever the user passes in
There was a problem hiding this comment.
since that functionality is just used to validate the the repositories that are configured on the host, is there a major concern with making it a passthrough. Unless we perform a simple regex (x.x)
There was a problem hiding this comment.
I think a regex validation of the option would be the ideal case... I would also (for now) restrict it to a format of "3.x"
There was a problem hiding this comment.
we can push this to a future PR.
|
@sabre1041 go ahead and do your review, and then merge if you want. |
* added option to check for selinux booleans * updated to now specify different file hashes depending on the version of docker * Changed the output headings for better readability
What does this PR do?
This addresses #245
How should this be manually tested?
./validate_pre-install.py` --ansible-host-file=/etc/ansible/hosts --show-sha-sums=yes --ansible-ssh-user=root --openshift-version=3.3 --private-registryThe --private-registry is optional. If it is not set, the script does not check the sum of
/etc/sysconfig/dockeranymore as it is no longer necessary to modify this file by hand in the default configurationWho would you like to review this?
/cc @etsauer @oybed