Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for conversion of 8-bit audio #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Schevv
Copy link

@Schevv Schevv commented Jul 31, 2024

When converting wave audio that is 8 bit (either input or output format) with audioop we need to care about the signedness of the 8-bit audio (see docs for audioop.lin2lin)

@synesthesiam
Copy link
Contributor

We need to add bias to pyaudioop first so this will continue working after Python 3.13 where they will drop the audioop module.

@synesthesiam synesthesiam self-assigned this Jul 31, 2024
@Schevv
Copy link
Author

Schevv commented Jul 31, 2024

Maybe it is easier in that case to replace the call to bias with a simple loop? It is simple to implement for the edge-case (8 bit) we have here. That is easier than to create the bias function for the general case and having to maintain it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants