Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade python versions to allow 3.11 installation and fix current pip installation failure #27

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

jmfrank63
Copy link

Currently tested on a Mac M1, this alongside the piper PR should fix
pip install piper-tts, which already created three issues.

Upgraded several python versions.
Windows and Linux, not tested yet.

@jmfrank63
Copy link
Author

This is now at a point, where some conversation should take place. Currently, MacOS and Windows are working and roughly tested. Linux will follow, but I do not expect the same chore as with Windows.
Both this and the piper are modified. If you want to run this, set an environment variable PIPER_PHONEMIZE_REPO and point it to your fork, so piper will load it.

@rmcpantoja
Copy link

rmcpantoja commented Feb 25, 2024

This is now at a point, where some conversation should take place. Currently, MacOS and Windows are working and roughly tested. Linux will follow, but I do not expect the same chore as with Windows. Both this and the piper are modified. If you want to run this, set an environment variable PIPER_PHONEMIZE_REPO and point it to your fork, so piper will load it.

Hi @jmfrank63,
How did you manage to do a wheel on Windows?

I tried through GitHub actions but got errors:
https://github.com/rmcpantoja/piper-phonemize/blob/master/.github/workflows/main.yml

@jmfrank63
Copy link
Author

I don't know exactly what kind of errors you are experiencing, but it might be the Unicode that is not understood by the Microsoft C-compiler. I changed the utf-8 characters to the hex representation and added conditional compilation for windows. But I must have made a mistake because it broke other languages except English, which now produce pure nonsense. Haven't had the time to look into this yet.

@rmcpantoja
Copy link

I don't know exactly what kind of errors you are experiencing, but it might be the Unicode that is not understood by the Microsoft C-compiler. I changed the utf-8 characters to the hex representation and added conditional compilation for windows. But I must have made a mistake because it broke other languages except English, which now produce pure nonsense. Haven't had the time to look into this yet.

You can see the full log here. It says it can't find espeak-ng/include, maibe I'm doing pip wheel in an wrong path...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants