Fix bug: L=A does not work with key repeat #5484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there is a PR open in pret, but no one from pret has looked at it and there does not seem to be interest in merging it, so I am putting it here just in case.
|
I recommend to not PR stuff to Expansion if it's still pending on pret. It might take months to be accepted there, but it'll eventually reach us anyway. |
|
Closing for now as we're waiting on a potential pret merge, please reopen if that isn't accepted! Pret PR for future reference: pret#2042 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there is a PR open in pret, but no one from pret has looked at it and there does not seem to be interest in merging it, so I am putting it here just in case.
Fix L=A mode
Description
Instead of comparing the mapped heldKeys, compare the heldKeysRaw
Discord contact info
RoseSilicon