Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo from original devs in original game: | should be || #5450

Closed
wants to merge 1 commit into from

Conversation

AreaZR
Copy link

@AreaZR AreaZR commented Oct 1, 2024

Doesn't fix any behavior, but it's just better this way.

Discord contact info

RSilicon

Doesn't fix any behavior, but it's just better this way.
@AsparagusEduardo
Copy link
Collaborator

Shouldn't this go to pret as a BUGFIX?

@AreaZR
Copy link
Author

AreaZR commented Oct 1, 2024

Shouldn't this go to pret as a BUGFIX?

Not really a bug fix. No bug is fixed here. Just a micro-op/compiler-warning-fix.

@Pawkkie
Copy link
Collaborator

Pawkkie commented Oct 1, 2024

Not really a bug fix. No bug is fixed here. Just a micro-op/compiler-warning-fix.

Shouldn't this go to pret as a BUGFIX micro-op?

@Bassoonian
Copy link
Collaborator

I agree that this should go to pret instead.

@AsparagusEduardo
Copy link
Collaborator

If it's a GF typo that affects performance, then it counts as a BUGFIX for pret imo. Wouldn't be the first typo of this type either.

@AlexOn1ine
Copy link
Collaborator

If it's a GF typo that affects performance, then it counts as a BUGFIX for pret imo. Wouldn't be the first typo of this type either.

Let's see if pret would accept such a pr and if they don't we can just merge this one.

@Pawkkie
Copy link
Collaborator

Pawkkie commented Oct 9, 2024

Just checking in, are you planning on PR'ing this to pret as requested?

@AreaZR
Copy link
Author

AreaZR commented Oct 10, 2024

Yes I will

@Bassoonian
Copy link
Collaborator

pret#2044

@Bassoonian
Copy link
Collaborator

As per the other PR, if this doesn't make it through pret, feel free to re-open

@Bassoonian Bassoonian closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants