Move controllers to internal/controllers
#715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openshift-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qbarrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
qbarrand
force-pushed
the
cp-7e339cbc980135257def6da7c328c8b99c8c8e2f
branch
from
0cd74e1
to
a8e6ed8
Compare
Rename NodeModulesConfigReconciler to NMCReconciler. Use private interfaces for the NMCReconciler for consistency. Upstream-Commit: 7e339cb
qbarrand
force-pushed
the
cp-7e339cbc980135257def6da7c328c8b99c8c8e2f
branch
from
a8e6ed8
to
68c6aae
Compare
|
/lgtm |
openshift-merge-robot
merged commit 35589fe
into
rh-ecosystem-edge:main
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
NodeModulesConfigReconcilertoNMCReconciler.Use private interfaces for the
NMCReconcilerfor consistency.Fixes #709
/cc @yevgeny-shnaidman