Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing NMC's controller watch object. #706

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

ybettan
Copy link
Collaborator

@ybettan ybettan commented Aug 22, 2023

We should watch for builds and not for jobs as we are not using jobs in this project.

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for openshift-kmm ready!

Name Link
🔨 Latest commit 83a3840
🔍 Latest deploy log https://app.netlify.com/sites/openshift-kmm/deploys/64e46606e1fd37000713995c
😎 Deploy Preview https://deploy-preview-706--openshift-kmm.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@openshift-ci
Copy link

openshift-ci bot commented Aug 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ybettan
Copy link
Collaborator Author

ybettan commented Aug 22, 2023

/cc @yevgeny-shnaidman @qbarrand

We should watch for builds and not for jobs as we are not using jobs in
this project.

Signed-off-by: Yoni Bettan <[email protected]>
@qbarrand
Copy link
Member

/lgtm

@qbarrand
Copy link
Member

/retest

6 similar comments
@qbarrand
Copy link
Member

/retest

@qbarrand
Copy link
Member

/retest

@ybettan
Copy link
Collaborator Author

ybettan commented Aug 22, 2023

/retest

@qbarrand
Copy link
Member

/retest

@qbarrand
Copy link
Member

/retest

@ybettan
Copy link
Collaborator Author

ybettan commented Aug 23, 2023

/retest

@openshift-merge-robot openshift-merge-robot merged commit 42e9b03 into rh-ecosystem-edge:main Aug 23, 2023
6 checks passed
@ybettan ybettan deleted the jobs-builds branch August 23, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants