Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding NodeModulesState type (#480) #666

Conversation

yevgeny-shnaidman
Copy link
Member

No description provided.

@openshift-ci
Copy link

openshift-ci bot commented Jul 23, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link

netlify bot commented Jul 23, 2023

Deploy Preview for openshift-kmm ready!

Name Link
🔨 Latest commit 15d429c
🔍 Latest deploy log https://app.netlify.com/sites/openshift-kmm/deploys/64bcd83996cb340008abd01c
😎 Deploy Preview https://deploy-preview-666--openshift-kmm.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yevgeny-shnaidman
Copy link
Member Author

/assign @ybettan

@codecov-commenter
Copy link

Codecov Report

Merging #666 (15d429c) into main (53a5ab3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #666      +/-   ##
==========================================
+ Coverage   79.21%   79.22%   +0.01%     
==========================================
  Files          39       40       +1     
  Lines        3589     3591       +2     
==========================================
+ Hits         2843     2845       +2     
  Misses        628      628              
  Partials      118      118              
Impacted Files Coverage Δ
api/v1beta1/nodemodulestate_types.go 100.00% <100.00%> (ø)

@ybettan
Copy link
Collaborator

ybettan commented Jul 23, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jul 23, 2023
@openshift-merge-robot openshift-merge-robot merged commit 6f81072 into rh-ecosystem-edge:main Jul 23, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants