Fixing module loading during kernel upgrade #1218
Merged
+48
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the node upgrade includes kernel upgrade, NMC Spec will change to include new kernel version. In that case NMC controller will try first to create unloader worker pod. Since the unloader worker pod uses the old configuration (from status), which uses the old image, the modprobe in the worker pod will fail, since it won't find kernel module under the /opt/lib/modules/<new kernel> path This PR fixes the issue by creating unloader pod in case of difference in spec and status of NMC only in case kernels are equal. Otherwise, it creates loader pod, since it means that node was rebooted, and the kernel module is not loaded yet, since the status contains old kernel
|
/assign @ybettan |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for openshift-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/lgtm |
openshift-merge-bot
bot
merged commit c076bba
into
rh-ecosystem-edge:main
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the node upgrade includes kernel upgrade, NMC Spec will change to include new kernel version. In that case NMC controller will try first to create unloader worker pod. Since the unloader worker pod uses the old configuration (from status), which uses the old image, the modprobe in the worker pod will fail, since it won't find kernel module under the /opt/lib/modules/ path
This PR fixes the issue by creating unloader pod in case of difference in spec and status of NMC only in case kernels are equal. Otherwise, it creates loader pod, since it means that node was rebooted, and the kernel module is not loaded yet, since the status contains old kernel