Copying firmware files in day1 feature #1216
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TomerNewman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for openshift-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
TomerNewman
force-pushed
the
feature/copying-firmware-day1-support
branch
from
b18e466
to
2102801
Compare
|
/retest |
| echo "removing kmm-pod" | ||
| podman pod rm $worker_pod_name |
There was a problem hiding this comment.
Won't the pod be automatically removed if all its containers are using the --rm flag?
There was a problem hiding this comment.
the pod remains with status of Exited, even though the containers were removed
| @@ -21,6 +21,7 @@ spec: | |||
| Type=oneshot | |||
| TimeoutSec=10 | |||
| EnvironmentFile=/etc/mco/proxy.env | |||
| Environment="FIRMWARE_FILES_PATH=/tmp/test" | |||
There was a problem hiding this comment.
I would use a path that is not in the /tmp directory.
Is this working with /tmp? I think that everything in /tmp in the container is going to be overwritten by the mounted directory isn't it?
There was a problem hiding this comment.
The unit test will pass but you're right, I will change it to a different path to make it consistent.
TomerNewman
force-pushed
the
feature/copying-firmware-day1-support
branch
2 times, most recently
from
e5e7635
to
69c6d74
Compare
After making KMM's day1 feature to copy the files using an init container, we also need to support copying firmware files. This PR adds the option to the user to add the path to the firmware files, and copy them.
TomerNewman
force-pushed
the
feature/copying-firmware-day1-support
branch
from
69c6d74
to
3c6649a
Compare
|
/retest |
|
/lgtm |
openshift-merge-bot
bot
merged commit 6bda6ab
into
rh-ecosystem-edge:main
After making KMM's day1 feature to copy the files using an init container, we also need to support copying firmware files.
This PR adds the option to the user to add the path to the firmware files, and copy them.
In addition, this PR deleting the pod in the end of the script.
/cc @ybettan @yevgeny-shnaidman