support inTree removal scenario for nodes without .ko files #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modprobe will fail with error in case it cannot find an appropriate .ko file when asked to remove a kernel module. With in-tree removal scenario, modporbe search path is /lib/modules on the host, and not the worker image. This PR contains the following: 1) Adding FileExists function that check the presence of a file under a search path based on a regexp 2) in worker flow, in case in-tree removal scenario is requisted, worker will verify if the requested .ko file(s) are present on the host, remove from the request missing files and will proceed with the removal scenario for the rest 3) unit-test
✅ Deploy Preview for openshift-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
Fixes1208 |
|
/test e2e |
3 similar comments
|
/test e2e |
|
/test e2e |
|
/test e2e |
|
/retest |
|
/test e2e-hub |
|
/test e2e |
|
/test operator-upgrade |
openshift-merge-bot
bot
merged commit ed8e38a
into
rh-ecosystem-edge:main
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modprobe will fail with error in case it cannot find an appropriate .ko file when asked to remove a kernel module. With in-tree removal scenario, modporbe search path is /lib/modules on the host, and not the worker image.
This PR contains the following:
a search path based on a regexp
will verify if the requested .ko file(s) are present on the host,
remove from the request missing files and will proceed with the
removal scenario for the rest