Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Testing CI #1207

Closed
wants to merge 1 commit into from
Closed

Conversation

ybettan
Copy link
Collaborator

@ybettan ybettan commented Sep 10, 2024


/hold

Do not merged

Copy link

openshift-ci bot commented Sep 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for openshift-kmm ready!

Name Link
🔨 Latest commit 6482421
🔍 Latest deploy log https://app.netlify.com/sites/openshift-kmm/deploys/66dfeaecc3f69a000890956e
😎 Deploy Preview https://deploy-preview-1207--openshift-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ybettan
Copy link
Collaborator Author

ybettan commented Sep 10, 2024

/uncc @enriquebelarte @yevgeny-shnaidman

Signed-off-by: Yoni Bettan <[email protected]>
Copy link

openshift-ci bot commented Sep 10, 2024

@ybettan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/check-api-changes 6482421 link true /test check-api-changes

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ybettan
Copy link
Collaborator Author

ybettan commented Sep 10, 2024

The check-api-changes job is working again. We got the correct error as expected:

++ git diff '-I^    createdAt: '
+ [[ -n diff --git a/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml b/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml
index 1ca4400c..25018237 100644
--- a/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml
+++ b/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml
@@ -16,7 +16,6 @@ data:
     worker:
       runAsUser: 0
       seLinuxType: spc_t
-      firmwareHostPath: /var/lib/firmware
 kind: ConfigMap
 metadata:
   labels: ]]
+ echo 'Please run `make generate bundle bundle-hub` and repush'
Please run `make generate bundle bundle-hub` and repush
+ echo 'The following differences were found:'
The following differences were found:
++ git diff '-I^    createdAt: '
+ echo diff --git a/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml b/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml index 1ca4400c..25018237 100644 --- a/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml +++ b/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml @@ -16,7 +16,6 @@ data: worker: runAsUser: 0 seLinuxType: spc_t - firmwareHostPath: /var/lib/firmware kind: ConfigMap metadata: labels:
diff --git a/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml b/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml index 1ca4400c..25018237 100644 --- a/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml +++ b/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml @@ -16,7 +16,6 @@ data: worker: runAsUser: 0 seLinuxType: spc_t - firmwareHostPath: /var/lib/firmware kind: ConfigMap metadata: labels:
+ exit 1

Closing the PR.

/close

Copy link

openshift-ci bot commented Sep 10, 2024

@ybettan: Closed this PR.

In response to this:

The check-api-changes job is working again. We got the correct error as expected:

++ git diff '-I^    createdAt: '
+ [[ -n diff --git a/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml b/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml
index 1ca4400c..25018237 100644
--- a/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml
+++ b/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml
@@ -16,7 +16,6 @@ data:
    worker:
      runAsUser: 0
      seLinuxType: spc_t
-      firmwareHostPath: /var/lib/firmware
kind: ConfigMap
metadata:
  labels: ]]
+ echo 'Please run `make generate bundle bundle-hub` and repush'
Please run `make generate bundle bundle-hub` and repush
+ echo 'The following differences were found:'
The following differences were found:
++ git diff '-I^    createdAt: '
+ echo diff --git a/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml b/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml index 1ca4400c..25018237 100644 --- a/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml +++ b/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml @@ -16,7 +16,6 @@ data: worker: runAsUser: 0 seLinuxType: spc_t - firmwareHostPath: /var/lib/firmware kind: ConfigMap metadata: labels:
diff --git a/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml b/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml index 1ca4400c..25018237 100644 --- a/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml +++ b/bundle/manifests/kmm-operator-manager-config_v1_configmap.yaml @@ -16,7 +16,6 @@ data: worker: runAsUser: 0 seLinuxType: spc_t - firmwareHostPath: /var/lib/firmware kind: ConfigMap metadata: labels:
+ exit 1

Closing the PR.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot closed this Sep 10, 2024
@ybettan ybettan deleted the test branch September 10, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant