Removing the ImageMounter interface. #1196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ybettan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for openshift-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ybettan
force-pushed
the
init-container-cleanup
branch
from
6eac0f9
to
525ab19
Compare
|
/unhold |
Now that we are using the cluster's container-runtime to pull the driver-container, then we don't need to manually pull and mount the images from the worker's code anymore. Signed-off-by: Yoni Bettan <[email protected]>
|
/lgtm |
openshift-merge-bot
bot
merged commit fece1ae
into
rh-ecosystem-edge:main
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we are using the cluster's container-runtime to pull the
driver-container, then we don't need to manually pull and mount the
images from the worker's code anymore.
Fixes #1195
/assign @yevgeny-shnaidman
/cc @TomerNewman
/hold
It should be merged after #1194 and rebased on top of it
@yevgeny-shnaidman can you please confirm that we don't need anymore
tarimagemounterfor day1?