Changing the FirmwarePath config flag #1172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) changing the setFirmwareClassPath flag to firmwareHostPath flag. This flag is used to: a) define the firmware path on the host b) define the mount point on the worker pod c) define the new firmware search path in the Linux kernel 2) updating NMC controller code to use the new flag for setting firmware volume for worker pods and passing parameters to worker pod entrypoint 3) updating unit-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for openshift-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/lgtm |
openshift-merge-bot
bot
merged commit 143bb98
into
rh-ecosystem-edge:main
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flag is used to:
a) define the firmware path on the host
b) define the mount point on the worker pod
c) define the new firmware search path in the Linux kernel
volume for worker pods and passing parameters to worker pod
entrypoint