Set a default value for setFirmwareClassPath in the worker config.
#1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ybettan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for openshift-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
When firmware is added to the driver-cotnainer there are 2 actions that were taken: 1. Copy the firmware files onto the node at `/var/lib/firmware` 2. Add `/var/lib/firmware` to `/sys/module/firmware_class/parameters/path` in order to update the kernel lookup directories for firmware files. In order to make this feature configurable, we will allow the user to choose the path on the nodes to write the firmware files to. In order to make it work with no additional changes, when firmware files are added to the driver-container, we added a default directory to add the firmware files to on the nodes. To keep it simple, we will also always add this path to the kernel lookup directories. Signed-off-by: Yoni Bettan <[email protected]>
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
openshift-merge-bot
bot
merged commit e8aa426
into
rh-ecosystem-edge:main
19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When firmware is added to the driver-cotnainer there are 2 actions that were taken:
/var/lib/firmware/var/lib/firmwareto/sys/module/firmware_class/parameters/pathin order to update the kernel lookup directories for firmware files.In order to make this feature configurable, we will allow the user to choose the path on the nodes to write the firmware files to.
In order to make it work with no additional changes, when firmware files are added to the driver-container, we added a default directory to add the firmware files to on the nodes.
To keep it simple, we will also always add this path to the kernel lookup directories.
Fixes #1169
/cc @yevgeny-shnaidman @TomerNewman