Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-17821: Normalize kernel version in labels and image tags #1135

Conversation

qbarrand
Copy link
Member

@qbarrand qbarrand commented Jun 3, 2024

Handle uncommon kernel versions with characters such as +, by replacing them with _.

Fixes #1134

/cc @ybettan @yevgeny-shnaidman

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 3, 2024

@qbarrand: This pull request references MGMT-17821 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

In response to this:

Handle uncommon kernel versions with characters such as +, by replacing them with _.

Fixes #1134

/cc @ybettan @yevgeny-shnaidman

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Jun 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qbarrand
Copy link
Member Author

qbarrand commented Jun 3, 2024

/test all

@openshift-ci openshift-ci bot added the approved label Jun 3, 2024
Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for openshift-kmm ready!

Name Link
🔨 Latest commit 7fafb7f
🔍 Latest deploy log https://app.netlify.com/sites/openshift-kmm/deploys/665de126c42ff600080efd01
😎 Deploy Preview https://deploy-preview-1135--openshift-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@qbarrand qbarrand marked this pull request as ready for review June 3, 2024 15:18
@qbarrand
Copy link
Member Author

qbarrand commented Jun 3, 2024

/cherry-pick release-2.1

@openshift-cherrypick-robot

@qbarrand: once the present PR merges, I will cherry-pick it on top of release-2.1 in a new PR and assign it to you.

In response to this:

/cherry-pick release-2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Handle uncommon kernel versions with characters such as +, by replacing
them with _.

Upstream-Commit: 3ac00e3
@qbarrand qbarrand force-pushed the cp-3ac00e36936af85f13ac892e4e63ea71d9fe0a26 branch from a721eb0 to 7fafb7f Compare June 3, 2024 15:28
@qbarrand
Copy link
Member Author

qbarrand commented Jun 3, 2024

/test security

@yevgeny-shnaidman
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 3, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit baaf1e8 into rh-ecosystem-edge:main Jun 3, 2024
19 checks passed
@openshift-cherrypick-robot

@qbarrand: new pull request created: #1138

In response to this:

/cherry-pick release-2.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qbarrand qbarrand deleted the cp-3ac00e36936af85f13ac892e4e63ea71d9fe0a26 branch June 3, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cherry-picking error for 3ac00e36936af85f13ac892e4e63ea71d9fe0a26
4 participants