Support cluster upgrade for day1 scenario #1076
Conversation
|
/assign @qbarrand |
✅ Deploy Preview for openshift-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yevgeny-shnaidman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1076 +/- ##
=======================================
Coverage 75.56% 75.56%
=======================================
Files 66 66
Lines 5909 5909
=======================================
Hits 4465 4465
Misses 1216 1216
Partials 228 228 ☔ View full report in Codecov by Sentry. |
pkg/mcproducer/scripts/pull-image.sh
Outdated
|
|
||
| if [ -e $kernel_module_image_filepath ]; then | ||
| echo "File $kernel_module_image_filepath found.Nothing to do, the file was handled, removing it" | ||
| echo "File $kernel_module_image_filepath found.Nothing to do, the file was handled, removing $kernel_module_image_filepath and $kmm_config_file_filepath" |
There was a problem hiding this comment.
| echo "File $kernel_module_image_filepath found.Nothing to do, the file was handled, removing $kernel_module_image_filepath and $kmm_config_file_filepath" | |
| echo "File $kernel_module_image_filepath found. Nothing to do, the file was handled, removing $kernel_module_image_filepath and $kmm_config_file_filepath" |
There was a problem hiding this comment.
why do we need space after dot?
There was a problem hiding this comment.
Because it clearer? Took me few seconds to realize it is not a Nothing field name in a found object :)
yevgeny-shnaidman
force-pushed
the
yevgeny/day1-cluster-upgrade
branch
2 times, most recently
from
c9a2fb4
to
8b2795f
Compare
yevgeny-shnaidman
force-pushed
the
yevgeny/day1-cluster-upgrade
branch
from
8b2795f
to
245d105
Compare
the kernel module image's tag should be equal to kernel version of the node. Pull image will get the current kernel version of the node and use this value as a tag for image to pull
yevgeny-shnaidman
force-pushed
the
yevgeny/day1-cluster-upgrade
branch
from
245d105
to
c1c8026
Compare
|
/lgtm |
openshift-merge-bot
bot
merged commit 9591126
into
rh-ecosystem-edge:main
the kernel module image's tag should be equal to kernel version of the node. Pull image will get the current kernel version of the node and use this value as a tag for image to pull