Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MGMT-17270: Add PreflightValidationOCP v1beta2 #1051

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

qbarrand
Copy link
Member

Make PreflightValidationOCP objects aware of Module namespaces to avoid cross-namespace collisions.
Add PreflightValidationOCP v1beta2 to restructure its status struct.
Add a conversion webhook for PreflightValidationOCP v1beta1 --> v1beta2.
Move the code updating the PreflightValidationOCP status from internal/statusupdater to internal/preflight to avoid a dependency cycle.
Update reconciler, libraries and unit tests.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 18, 2024

@qbarrand: This pull request references MGMT-17270 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Make PreflightValidationOCP objects aware of Module namespaces to avoid cross-namespace collisions.
Add PreflightValidationOCP v1beta2 to restructure its status struct.
Add a conversion webhook for PreflightValidationOCP v1beta1 --> v1beta2.
Move the code updating the PreflightValidationOCP status from internal/statusupdater to internal/preflight to avoid a dependency cycle.
Update reconciler, libraries and unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link

openshift-ci bot commented Mar 18, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for openshift-kmm ready!

Name Link
🔨 Latest commit eb1523e
🔍 Latest deploy log https://app.netlify.com/sites/openshift-kmm/deploys/65f89ce7fa24ab000899a1d3
😎 Deploy Preview https://deploy-preview-1051--openshift-kmm.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@qbarrand
Copy link
Member Author

Will be rebased after #1049 is merged.

Make PreflightValidationOCP objects aware of Module namespaces to avoid
cross-namespace collisions.
Add PreflightValidationOCP v1beta2 to restructure its status struct.
Add a conversion webhook for PreflightValidationOCP v1beta1 --> v1beta2.
Move the code updating the PreflightValidationOCP status from
internal/statusupdater to internal/preflight to avoid a dependency cycle.
Update reconciler, libraries and unit tests.
@yevgeny-shnaidman
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 650e93f into rh-ecosystem-edge:main Mar 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants