-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MGMT-17270: Add PreflightValidationOCP v1beta2 #1051
MGMT-17270: Add PreflightValidationOCP v1beta2 #1051
Conversation
@qbarrand: This pull request references MGMT-17270 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qbarrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for openshift-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Will be rebased after #1049 is merged. |
Make PreflightValidationOCP objects aware of Module namespaces to avoid cross-namespace collisions. Add PreflightValidationOCP v1beta2 to restructure its status struct. Add a conversion webhook for PreflightValidationOCP v1beta1 --> v1beta2. Move the code updating the PreflightValidationOCP status from internal/statusupdater to internal/preflight to avoid a dependency cycle. Update reconciler, libraries and unit tests.
9422214
to
eb1523e
Compare
/lgtm |
650e93f
into
rh-ecosystem-edge:main
Make
PreflightValidationOCP
objects aware ofModule
namespaces to avoid cross-namespace collisions.Add
PreflightValidationOCP
v1beta2
to restructure its status struct.Add a conversion webhook for
PreflightValidationOCP
v1beta1
-->v1beta2
.Move the code updating the PreflightValidationOCP status from
internal/statusupdater
tointernal/preflight
to avoid a dependency cycle.Update reconciler, libraries and unit tests.