add MissingRequiredField error #59
Conversation
harambe/errors.py
Outdated
| @@ -12,6 +12,13 @@ def __init__(self, schema: Schema, data: ScrapeResult, message: str): | |||
| super().__init__(f"Data {data} does not match schema {schema}. {message}") | |||
There was a problem hiding this comment.
Let's put the message first. It will often get lost in the sauce
test/parser/test_parser.py
Outdated
| ), | ||
| ], | ||
| ) | ||
| def test_missing_required_field_error( |
There was a problem hiding this comment.
There is an existing test_required_fields test. Can we append to the existing parameterized tests??
test/parser/test_parser.py
Outdated
| {}, # ❌ Missing the required "name" field | ||
| ["name"], | ||
| ), | ||
| # Test Case 2: Multiple required fields missing |
There was a problem hiding this comment.
These numberings aren't too helpful and annoying to manage as we move things around. Need to at least get rid of the number (I know we have a bunch of tests that have this, we should delete that junk)
test/parser/test_required_fields.py
Outdated
| ), | ||
| ], | ||
| ) | ||
| def test_missing_required_field_error( |
There was a problem hiding this comment.
def test_pydantic_schema_validation_error_fail(
There is a already a failure case function at the top of the file. Let's append to that
harambe/__init__.py
Outdated
| @@ -11,4 +17,8 @@ | |||
| "AsyncScraperType", | |||
| "AsyncScraper", | |||
| "PAGE_PDF_FILENAME", | |||
| "HarambeException", | |||
| "SchemaValidationError", | |||
| "MissingRequiredFieldError", | |||
There was a problem hiding this comment.
| "MissingRequiredFieldError", | |
| "MissingRequiredFieldsError", |
This should be plural. We will report all missing fields, not just one
test/parser/test_required_fields.py
Outdated
| @pytest.mark.parametrize( | ||
| "schema, data, missing_fields", | ||
| [ | ||
| ( | ||
| { | ||
| "name": { | ||
| "type": "string", | ||
| "required": True, | ||
| "description": "The name of the person", | ||
| } | ||
| }, | ||
| {}, # ❌ Missing the required "name" field | ||
| ["name"], | ||
| ), |
There was a problem hiding this comment.
this whole test function is a duplicate now
…_required_fields to handle nested lists properly
No description provided.