Fixed some banana seeds edge case & error catching #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+326
to
+341
| missing_mhtml = [] | ||
| for i, example in enumerate(examples): | ||
| if example.mhtml_url is not None: | ||
| mhtml_path = get_examples_path() / example.id / "index.mhtml" | ||
| if not mhtml_path.exists(): | ||
| mhtml_str = download_mhtml(example.mhtml_url) | ||
| mhtml_path.parent.mkdir(parents=True, exist_ok=False) | ||
| with open(mhtml_path, "w") as file: | ||
| file.write(mhtml_str) | ||
| try: | ||
| mhtml_str = download_mhtml(example.mhtml_url) | ||
| except ClientError: | ||
| missing_mhtml.append(i) | ||
| continue | ||
| else: | ||
| mhtml_path.parent.mkdir(parents=True, exist_ok=False) | ||
| with open(mhtml_path, "w") as file: | ||
| file.write(mhtml_str) | ||
|
|
||
| examples = [e for i, e in enumerate(examples) if i not in missing_mhtml] |
There was a problem hiding this comment.
should just delete the id missing mhtml or handle it directly. Don't think we need handling for this (and could cause us to misunderstand how many tests we really have)
|
@KhoomeiK please get this is in or close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.