Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements and clarifications on Croatian digraphs (not ligatures) #500

Merged
merged 7 commits into from
Dec 10, 2021

Conversation

ivankokan
Copy link
Contributor

@jspitz
Copy link
Collaborator

jspitz commented Apr 23, 2021

This is a controversial issue, see #497. My personal take is that this something to be addressed in the hyphenation patterns.

@ivankokan ivankokan changed the title Update gloss-croatian.ldf Improvements and clarifications on Croatian digraphs (not ligatures) Apr 24, 2021
The backwards compatibility for `disableligatures` is not needed as the name itself is misleading and such relatively new option has been barely used.
@ivankokan
Copy link
Contributor Author

ivankokan commented Apr 25, 2021

This PR includes:

  1. renaming the Croatian option disableligatures to disabledigraphs without preserving backwards compatibility (it is not needed as the current name is wrong and misleading & such a relatively new option has been barely used) - DŽ, LJ and NJ are simply not ligatures (compared to ambiguous IJ, or truly the ligature &) but digraph letters (correspond to phonemes that differ from consecutive , LJ and NJ)
  2. preserve the current polyglossia's behavior when disableligatures is set as it was initially planned (Croatian digraphs: When the digraph is to be output and the font is missing one, mimic it #497 (comment)) - a common way of typesetting in Croatian & "I do not want digraphs at all when I set this option"
  3. change the fallback for missing Unicode digraph in a font: instead of falling back to the common way of typesetting (but orthographically incorrect), in this case the digraph (letter) gets mimicked by the two consecutive glyphs - compared to @jspitz's initial idea (Croatian digraphs: When the digraph is to be output and the font is missing one, mimic it #497 (comment)), \nobreak is semantically the best choice & it is being used in many other places within polyglossia (along with its equivalent \penalty\@M)
  4. carefully improved manual when it comes to terms "letters", "glyphs", "characters" etc.

@jspitz
Copy link
Collaborator

jspitz commented Jun 26, 2021

Please provide a PR with only the renaming, not change in function. Please provide an alias disableligatures > disabledigraphs for backwards compatibility.

@jspitz jspitz merged commit 05a929e into reutenauer:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants