1.21.2/1.21.3 update #975
Merged
1.21.2/1.21.3 update #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Could potentially solve retrooper#962, although I can't reproduce that issue This may be caused by two different changes to packetevents: 1. We did a little memory optimization so only elements different to the vanilly registry get stored 2. We fixed an issue where some elements would not equal the "same" vanilla element This could cause every custom element to just never be registered, so we now do explicit deep-equals checks before saving the vanilla element instead
|
Booky on it again 💪🏻 Extremely cool to see you constantly working on the latest snapshot support, so PacketEvents supports the latest Minecraft release almost the moment it drops! |
Recipe display types are too much work for now, I'll do them later Also, mojang has removed the ability for custom item recipes... for whatever reason?
Didn't think I would have updated this already, but its already up-to-date! Yay!
Also refactors it's logic into a common class, as it was previously split in config and play state packets
|
I've tested re-encoding all packets (especially recipes) with a fabric server and fabric client, so this PR should be ready |
|
1.21.2 has been released an hour ago and this PR has now been tested on Spigot 1.21.2. |
Thanks mojang for fixing the salmon!
|
Mojang has released 1.21.3, fixing crucial bugs, such as salmons being too small. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test build downloads: https://github.com/retrooper/packetevents/actions/runs/11483962127This has been merged, please use https://ci.codemc.io/job/retrooper/job/packetevents/ instead.
Third snapshot was released last wednesday, so the release will probably still take some time.Rc1 was released on thursday, so the release will probably happen next week tuesday.This PR should be complete and ready, after testing.Vanilla 1.21.2 and Spigot 1.21.2 are out, I've tested this PR on Fabric 1.21.2 and Spigot 1.21.2.
Additionally, I've tested this PR on 1.20.6, 1.16.2 and 1.8.8.
TODO
WrapperPlayServerRecipeBookSettingsRecipeDisplay...Noteworthy changes:
WrapperPlayServerSetPlayerInventoryandWrapperPlayServerSetCursorItemrespectivelyWrapperPlayServerSetSlotpackets to these new packets for nowBOATentity type andCHEST_BOATentity types have been split into separate entity types for each boat typeFixes #1039