-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Awakeable id format changes #47
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,8 +18,12 @@ message StartMessage { | |
bytes value = 2; | ||
} | ||
|
||
bytes invocation_id = 1; | ||
bytes instance_key = 2; | ||
// Unique id of the invocation. This id is unique across invocations and won't change when replaying the journal. | ||
bytes id = 1; | ||
|
||
// Invocation id that can be used for logging. | ||
// The user can use this id to address this invocation in admin and status introspection apis. | ||
string debug_id = 2; | ||
|
||
uint32 known_entries = 3; | ||
|
||
|
@@ -162,6 +166,7 @@ message BackgroundInvokeEntryMessage { | |
|
||
// Kind: Completable JournalEntry | ||
// Type: 0x0C00 + 3 | ||
// Awakeables are addressed by an identifier exposed to the user. See the spec for more details. | ||
message AwakeableEntryMessage { | ||
oneof result { | ||
bytes value = 14; | ||
|
@@ -172,10 +177,8 @@ message AwakeableEntryMessage { | |
// Kind: Non-Completable JournalEntry | ||
// Type: 0x0C00 + 4 | ||
message CompleteAwakeableEntryMessage { | ||
string service_name = 1; | ||
bytes instance_key = 2; | ||
bytes invocation_id = 3; | ||
uint32 entry_index = 4; | ||
// Identifier of the awakeable. See the spec for more details. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe say that this is the base64 encoded form of the awakeable identifier. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure this adds more than what is already described in the spec. |
||
string id = 1; | ||
|
||
oneof result { | ||
bytes value = 5; | ||
|
@@ -196,12 +199,3 @@ message Failure { | |
// Contains a concise error message, e.g. Throwable#getMessage() in Java. | ||
string message = 2; | ||
} | ||
|
||
// --- Other types | ||
|
||
message AwakeableIdentifier { | ||
string service_name = 1; | ||
bytes instance_key = 2; | ||
bytes invocation_id = 3; | ||
uint32 entry_index = 4; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
id
in the runtime world is partition_key + invocation_id, but in sdk terms it doesn't really matter, this is just what you need to concatenate with the awakeable index.